New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: remove dependency on deprecated gogo/protobuf #268

Open

krajorama opened this issue Nov 30, 2022 · 1 comment

Contributor

krajorama commented Nov 30, 2022

Remove dependency on https://github.com/gogo/protobuf .

This would be a breaking change, thus requires a major version bump.

Collaborator

bboreham commented Mar 17, 2023

The reason for picking gogo/protobuf was performance: I would like to be confident that we are moving to one with equal or better performance.

(It shouldn't be a massive ask for httpgrpc which is essentially transporting one string, but still)

duricanikolic mentioned this issue

httpgrpc: correct handling of non-loggable errors grafana/dskit#421

Merged

2 tasks

aknuds1 mentioned this issue

Migrate away from github.com/gogo/protobuf grafana/mimir#6543

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment