From 9c58f093483f006af0ca95404546a24290dac3ef Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Sat, 23 Apr 2022 11:11:53 +0200 Subject: [PATCH 1/5] Update default runtime to node16 --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index add103f8..b9fc21de 100644 --- a/action.yml +++ b/action.yml @@ -513,7 +513,7 @@ inputs: default: "true" runs: - using: node12 + using: node16 main: ./dist/index.js branding: From 19d8c1579102140353b0d39774ff860086d36481 Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Sat, 23 Apr 2022 11:14:51 +0200 Subject: [PATCH 2/5] Add Node version file and use it in workflows --- .github/workflows/build.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/test-action.yml | 2 +- .github/workflows/test.yml | 2 +- .nvmrc | 1 + 5 files changed, 5 insertions(+), 4 deletions(-) create mode 100644 .nvmrc diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0b382769..7d00f69a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,7 +27,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version: 12 + node-version-file: '.nvmrc' - name: Get yarn cache directory path id: yarn-cache-dir-path diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 1af5bccc..d3970a43 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -27,7 +27,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version: 12 + node-version-file: '.nvmrc' - name: Get yarn cache directory path id: yarn-cache-dir-path diff --git a/.github/workflows/test-action.yml b/.github/workflows/test-action.yml index d32be6bc..a7427eda 100644 --- a/.github/workflows/test-action.yml +++ b/.github/workflows/test-action.yml @@ -39,7 +39,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version: 12 + node-version-file: '.nvmrc' - name: Install dependencies run: yarn install diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e95e025f..e3ccea80 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -48,7 +48,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version: 12 + node-version-file: '.nvmrc' - name: Get yarn cache directory path id: yarn-cache-dir-path diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 00000000..b6a7d89c --- /dev/null +++ b/.nvmrc @@ -0,0 +1 @@ +16 From a6c9ea1dbf673314428f5c86cbafb853b7ac38bd Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Sat, 23 Apr 2022 11:17:21 +0200 Subject: [PATCH 3/5] Fix formatting --- .github/workflows/build.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/test-action.yml | 2 +- .github/workflows/test.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 7d00f69a..c1d5bd01 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -27,7 +27,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version-file: ".nvmrc" - name: Get yarn cache directory path id: yarn-cache-dir-path diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index d3970a43..c78f8c78 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -27,7 +27,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version-file: ".nvmrc" - name: Get yarn cache directory path id: yarn-cache-dir-path diff --git a/.github/workflows/test-action.yml b/.github/workflows/test-action.yml index a7427eda..51465218 100644 --- a/.github/workflows/test-action.yml +++ b/.github/workflows/test-action.yml @@ -39,7 +39,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version-file: ".nvmrc" - name: Install dependencies run: yarn install diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e3ccea80..3348a185 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -48,7 +48,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version-file: ".nvmrc" - name: Get yarn cache directory path id: yarn-cache-dir-path From 38bea1706cd2c3b50dc417f952abd9e5a42821d7 Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Sat, 23 Apr 2022 11:21:35 +0200 Subject: [PATCH 4/5] Use built-in cache from actions/setup-node for yarn --- .github/workflows/build.yml | 13 +------------ .github/workflows/lint.yml | 13 +------------ .github/workflows/test-action.yml | 1 + 3 files changed, 3 insertions(+), 24 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c1d5bd01..2ae80891 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -28,18 +28,7 @@ jobs: uses: actions/setup-node@v3 with: node-version-file: ".nvmrc" - - - name: Get yarn cache directory path - id: yarn-cache-dir-path - run: echo "::set-output name=dir::$(yarn cache dir)" - - - name: Set up cache - uses: actions/cache@v3 - with: - path: ${{ steps.yarn-cache-dir-path.outputs.dir }} - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.os }}-yarn- + cache: 'yarn' - name: Install dependencies run: yarn install diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index c78f8c78..732c5098 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -28,18 +28,7 @@ jobs: uses: actions/setup-node@v3 with: node-version-file: ".nvmrc" - - - name: Get yarn cache directory path - id: yarn-cache-dir-path - run: echo "::set-output name=dir::$(yarn cache dir)" - - - name: Set up cache - uses: actions/cache@v3 - with: - path: ${{ steps.yarn-cache-dir-path.outputs.dir }} - key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} - restore-keys: | - ${{ runner.os }}-yarn- + cache: 'yarn' - name: Install dependencies run: yarn install diff --git a/.github/workflows/test-action.yml b/.github/workflows/test-action.yml index 51465218..89f0940d 100644 --- a/.github/workflows/test-action.yml +++ b/.github/workflows/test-action.yml @@ -40,6 +40,7 @@ jobs: uses: actions/setup-node@v3 with: node-version-file: ".nvmrc" + cache: 'yarn' - name: Install dependencies run: yarn install From 5e6560b7475f6ae974f1e31b9615f2a0cdd0600c Mon Sep 17 00:00:00 2001 From: Dominik Schilling Date: Sat, 23 Apr 2022 11:30:04 +0200 Subject: [PATCH 5/5] Fix formatting --- .github/workflows/build.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/test-action.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2ae80891..2862ca33 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -28,7 +28,7 @@ jobs: uses: actions/setup-node@v3 with: node-version-file: ".nvmrc" - cache: 'yarn' + cache: "yarn" - name: Install dependencies run: yarn install diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 732c5098..c0236808 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -28,7 +28,7 @@ jobs: uses: actions/setup-node@v3 with: node-version-file: ".nvmrc" - cache: 'yarn' + cache: "yarn" - name: Install dependencies run: yarn install diff --git a/.github/workflows/test-action.yml b/.github/workflows/test-action.yml index 89f0940d..6ce4937c 100644 --- a/.github/workflows/test-action.yml +++ b/.github/workflows/test-action.yml @@ -40,7 +40,7 @@ jobs: uses: actions/setup-node@v3 with: node-version-file: ".nvmrc" - cache: 'yarn' + cache: "yarn" - name: Install dependencies run: yarn install