Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-fixing on pull requests is not committing #19

Closed
larsklevan opened this issue Feb 12, 2020 · 2 comments
Closed

Auto-fixing on pull requests is not committing #19

larsklevan opened this issue Feb 12, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@larsklevan
Copy link

After upgrading from 0.7.9 to 1.1.0 our team noticed that some lint violations had crept in. They were all autofixable so I'm wondering if the diff detection is not working?

0.7.9:

Verifying setup for RuboCop…
Verified RuboCop setup
Will use RuboCop to check the files with extensions rb
Linting and auto-fixing files in /home/runner/work/project/project with RuboCop…
RuboCop found no issues (success)
Committing changes
Pushing changes to ***github.com/company/project.git
To https://github.com/company/project.git

It's not obvious from the log in 0.7.9 but it did push an autofix commit.

1.1.0:

Verifying setup for RuboCop…
Verified RuboCop setup
Will use RuboCop to check the files with extensions rb
Linting and auto-fixing files in /home/runner/work/project/project with RuboCop…
RuboCop found no issues (success)

In 1.1.0 no autofix commit was pushed

@samuelmeuli
Copy link
Collaborator

Probably a duplicate of #18. I've released a fix a few minutes again. Could you please try rerunning your workflow? :)

@larsklevan
Copy link
Author

You're right - verified that 1.2.0 fixes it!

@samuelmeuli samuelmeuli added the duplicate This issue or pull request already exists label Feb 12, 2020
@samuelmeuli samuelmeuli changed the title linters falsely passing in 1.1.0 Auto-fixing on pull requests is not committing Feb 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants