Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding support for lifecycle components #82

Open
ryanmoelter opened this issue May 30, 2018 · 0 comments
Open

Consider adding support for lifecycle components #82

ryanmoelter opened this issue May 30, 2018 · 0 comments
Labels

Comments

@ryanmoelter
Copy link
Contributor

ryanmoelter commented May 30, 2018

We could add support for lifecycle-aware components by implementing LifecycleOwner in either the Screen or Navigator (or both?). Magellan is designed to make things like ViewModels unnecessary, but it would still be nice to have.

[https://developer.android.com/topic/libraries/architecture/lifecycle](Here are the developer docs) for more details.

We may even consider rebuilding screens on top of that lifecycle. I don't particularly like the API (why annotations?) but it might be worth using for a few reasons:

  • It's the google-approved way to handle lifecycles
  • Other libraries have lifecycle-aware versions
  • They have a working implementation of the state machine (LifecycleRegistry) that we can use
@ryanmoelter ryanmoelter added this to the v1.x milestone Sep 28, 2018
@ryanmoelter ryanmoelter removed this from the v1.x milestone Sep 28, 2018
@ryanmoelter ryanmoelter added this to the v1.3: Composition milestone May 19, 2019
@ryanmoelter ryanmoelter removed this from the v1.3: Composition milestone Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant