Skip to content
This repository has been archived by the owner on Apr 1, 2023. It is now read-only.

Bookmark all tabs and import/export bookmarks #26

Closed
DragoCubed opened this issue May 31, 2020 · 8 comments
Closed

Bookmark all tabs and import/export bookmarks #26

DragoCubed opened this issue May 31, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@DragoCubed
Copy link

DragoCubed commented May 31, 2020

Is your feature request fall into the scope of ungoogled-chromium?
Please explain why the feature request aligns with the goal of ungoogled-chromium. [...]
In one word: freedom. Google currently tells users to use Chrome Sync to open all of their tabs from their mobile device on their desktop device and to bookmark all of them there. You also cannot import or export bookmarks.

Please describe the feature you would like to have
A clear and concise description of what the problem is. [...]
Users are trapped with tabs (and bookmarks)

Describe the solution you'd like
A clear and concise description of what you want to happen.
Bookmark all tabs and import/export bookmarks (if not added already). The Brave and Chromium issues linked below have a bunch of ideas. Basically the consensus is:

  • a bookmark all tabs menu item in the tab switcher
  • a dialog like the download dialog that lets you add a name to the folder and choose a parent folder. the default name is "New folder" and the default location is the mobile bookmarks folder and then the last set location. Tapping on the folder part of the dialog would show the choose bookmark folder screen that lets you select a parent folder.
  • tab groups would be a subfolder and retain their name

Bromite patch for importing/exporting bookmarks

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Perhaps exporting and importing tabs to a file? This is what various extensions such as The Great Suspender do.

Additional context
Add any other context or screenshots about the feature request here.
brave/brave-browser#9443
Download prompt:
image
Choose folder:
choose folder chrome
Edit bookmark:
edit bookmark

Bookmark all tabs dialog on desktop:
image

@wchen342
Copy link
Owner

wchen342 commented May 31, 2020

I think this is a reasonable feature. I have one question though, the first screenshot you posted is showing downloading of an apk. What is that related to?

PS: I saw your issue at Bromite. I think if you explained as you did here maybe @csagan5 will consider this too.

EDIT: ok I see it is just an example for saving the bookmarks. Now I get the idea.

@wchen342 wchen342 added the enhancement New feature or request label May 31, 2020
@DragoCubed
Copy link
Author

DragoCubed commented Jun 1, 2020

Thank you for your reply!
yeah. as you figured out, the download prompt is one point of inspiration for the UI. The UI could alternatively be the like the edit bookmark screen. One's a dialog, the other is fullscreen. People were suggesting the dialog in various places but perhaps a screen would be more suitable.
By the way here's Google's response. I've seen them mention using Sync elsewhere but I've only bookmarked that one.

@DragoCubed
Copy link
Author

@wchen342 google literally said this: https://bugs.chromium.org/p/chromium/issues/detail?id=1026222#c20 and marked it as wontfix with a bunch of bullshit

@wchen342
Copy link
Owner

wchen342 commented Jun 2, 2020

Well I won't comment on why they made the decision but technically it shouldn't be so hard for them to add this (they don't even need to modify C++ codes, only Android codes unless they want to optimize for opening 100+ tabs at the same time, but I doubt Android can handle that many tabs anyway).

@DragoCubed DragoCubed changed the title Bookmark all tabs Bookmark all tabs and import/export bookmarks Jun 2, 2020
@csagan5
Copy link
Contributor

csagan5 commented Jun 2, 2020

PS: I saw your issue at Bromite. I think if you explained as you did here maybe @csagan5 will consider this too.

Ok, so this is a feature which already works on desktop. The only difficult part to implement would be the dialog, see https://github.com/chromium/chromium/blob/83.0.4103.93/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc#L181 (I don't think that is going to work on Android).

This feature has gone through some evolution, see the original implementation in 2009: chromium/chromium@b3ac5c8#diff-ef00add727ca12536c383b5f9e8fffbeR626

The feature could be implemented without the UI, using some automatically-generated folder name. I might add it in such way in Bromite.

@wchen342
Copy link
Owner

wchen342 commented Jun 2, 2020

@csagan5 Interesting. It seems only the open window part needs to be substituted. If you are going to work on this then I will leave this to you.

@csagan5
Copy link
Contributor

csagan5 commented Jun 2, 2020

@wchen342 not on the window part, you can work on that if you like - either now or after I have some PoC.

@wchen342
Copy link
Owner

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants