Add knit_print method for webshot #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can avoid importing knitr. See https://github.com/ramnathv/htmlwidgets/blob/master/R/knitr-methods.R for an example. |
|
I actually had seen that code when I was doing this originally, thought you might not want the added complexity. 8ae7e27 keeps knitr in Suggests and uses the referenced functions. |
| S3method(print,webshot) | ||
| export("%>%") | ||
| export(appshot) | ||
| export(install_phantomjs) | ||
| export(knit_print.webshot) |
There was a problem hiding this comment.
I guess this does not need to be exported.
|
Could you also update the functions in image.R to check for the webshot class and also return a filename with that class? Otherwise, I think that doing something like |
|
@wch Ok both shrink and resize now also return webshot objects as well. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets you include
webshot()calls directly in knitted documents and automatically show the output image.The object must be returned visibly in order to show up when knitting, so I had to define a print method as well to preserve the previous behavior.