Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fields status and reason in SCA #674

Closed
3 tasks done
juankaromo opened this issue Apr 25, 2019 · 1 comment
Closed
3 tasks done

New fields status and reason in SCA #674

juankaromo opened this issue Apr 25, 2019 · 1 comment
Assignees
Labels
type/enhancement Enhancement issue

Comments

@juankaromo
Copy link
Contributor

juankaromo commented Apr 25, 2019

Hi team,

Currently, the SCA section shows all policies checks with passed or failed results only. This may derivate in falses positives when any rule has been unable to be scanned for any reason. For these cases, when we cannot mark that check as passed, new fields have been created for this not applicable checks (status) and supported by a reason when possible. In this case, the result field is missing in favor of status and reason. wazuh/wazuh#3029 and wazuh/wazuh#3169

We need to show these new fields properly in the app.

  • Adapt visualization based on passed/failed (Add angular-charts)
  • Show checks status if the policy is not passed either failed
  • In these cases, when the check row is expanded, we need to show the reason why the policy was not passed yet

Regards.

@juankaromo juankaromo added the type/enhancement Enhancement issue label Apr 25, 2019
@adri9valle adri9valle added this to the 17th week sprint milestone Apr 25, 2019
@adri9valle
Copy link
Contributor

Solved: #668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

3 participants