Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested states #669

Closed
15 tasks done
adri9valle opened this issue Apr 22, 2019 · 4 comments
Closed
15 tasks done

Nested states #669

adri9valle opened this issue Apr 22, 2019 · 4 comments
Assignees
Labels
type/enhancement Enhancement issue

Comments

@adri9valle
Copy link
Contributor

adri9valle commented Apr 22, 2019

Hi team,

In the Wazuh App for Splunk when changing between sections all the content is loaded, this is because we are using a complete state for each section. It would be nice to use the nested states of ui-router in order to improve the App navigation between some sections.

  • Overview:

    • Security Information Management
    • Auditing and Policy Monitoring
    • Threat Detection and Response
    • Regulatory Compliance
  • Management:

    • Ruleset (Rules, decoders and CDB lists)
    • Status and reports
  • Agents:

    • Security Information Management
    • Auditing and Policy Monitoring
    • Threat Detection and Response
    • Regulatory Compliance
  • Settings:

    • API
    • Extensions
    • Index
    • Logs
    • About

Regards,

@adri9valle adri9valle added the type/enhancement Enhancement issue label Apr 22, 2019
@jesusgn90 jesusgn90 added this to the 17th week sprint milestone Apr 22, 2019
@adri9valle
Copy link
Contributor Author

Update 10.05.19 :

I have done the first approach, trying to set the ow-general state as a child of another new state.
Once this works ok I'll implement in ow-fim and ow-aws.

Working branch: nested-states

@adri9valle
Copy link
Contributor Author

Update 13.05.19 :

I finally didn't use the nested-states de ui-router.

I've been looking for and testing the most effective way to improve navigation and eliminate duplicate functions and event listeners.

Today I have created a parent class for Overview and implemented it in all sections.

I changed the working branch.

Status: In progress
Working branch: improve-states
PR: #702

@adri9valle
Copy link
Contributor Author

adri9valle commented May 14, 2019

Update 14.05.19:

  • OverviewMain is now DashboardMain and has been changed in all Overview sections.
  • All Agents sections are using DashboardMain as parent Class now, this improve the code preventing duplicates function.
  • Copyright headers has been added in all the Controller files that I've checked.
  • Removed unused services, variables, etc in the controllers.
  • Fix reports, some elements as tables were not contemplated, now are added.
  • Replace if (!this.scope.$$phase) this.scope.$digest(), if (!$scope.$$phase) $scope.$digest() and for this.scope.$applyAsync(), $scope.$applyAsync() and this.$rootScope.$applyAsync() globally
  • Increase realtime refresh time to 5 seconds.

I have finished the issue except in Manager > Logs section when changing between section if the wz-config-viewer has not finished loading the XMLContent the transition effect is not applied. I'm looking for a solution.

Working branch: improve-states
PR: #702

@adri9valle
Copy link
Contributor Author

Update 23.05.19

  • Solved flicks between primary states
  • Removed loadingContent to avoid flicks between secondary states

Visually it's the same but the code has improved avoiding duplicate functions and listeners in the dashboard controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

2 participants