Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Security < Users section #1184

Open
2 tasks
AlexRuiz7 opened this issue Dec 31, 2021 · 1 comment
Open
2 tasks

Improve the Security < Users section #1184

AlexRuiz7 opened this issue Dec 31, 2021 · 1 comment
Labels
type/enhancement Enhancement issue

Comments

@AlexRuiz7
Copy link
Member

AlexRuiz7 commented Dec 31, 2021

Improve the Security < Users view

image

  1. The allow run_as checkbox could be replaced by a switch. The text is too big, and its location does not make much sense.

  2. When a new user is created, the run_as option is shown as a number (0 or 1) instead of a boolean (true or false).
    image

  3. The run_as option could be improved to show a check or cross icon instead of true or false, as done on the Settings < API section.
    image

  4. In order to create a new user, 4 requests are performed, and some of them are not required.

    • POST /security/users : required, creates a new user with username:password.
    • PUT /security/users/{user_id]/run_as : only required if the run_as checkbox has been checked. Otherwise, the run_as option on the new user has been set to false by default on the previous request, and thus, it is not needed to perform a request to set the run_as to false again.
    • POST /security/users/100/roles?role_ids=[{roles_ids}] : same as before. If no role is specified during the creation of the user, then this request is not needed.
  5. The UI to create a new user can be greatly improved.

    • Using a warning toast to describe the password's requirements does not look like the better approach. IMO, it could be replaced with a list somewhere on the UI, as there is plenty of unused space. Ideally, a real-time password checker could be used. Example here
    • The password fields could use a toggle function (button) to show the password in legible text, as seen here.
    • The UI can be re-distributed better, as there is too much empty space on the left (the display is too vertical)

Alternatives

  • Improve the workflow for an user creation, performing only the requests strictly necessary.
  • Improve the UI.
@AlexRuiz7
Copy link
Member Author

Related issue: #1254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

2 participants