Fix events view when search bar language is lucene #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wazuh dashboardLegend: UI
Details 🟢 The Modules//Events page should be displayed when the Lucene query language is selected in the search barChrome - 🟢 Firefox - 🟢 🟢 When there are no results for query and selecting Lucene as the query language, the message should display OpenSearchChrome - 🟢 Firefox - 🟢
|
Desvelao
approved these changes
Mar 13, 2023
Machi3mfl
approved these changes
Mar 13, 2023
There was a problem hiding this comment.
Wazuh dashboard
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox |
|---|---|---|
| The Modules//Events page should be displayed when the Lucene query language is selected in the search bar | 🟢 | ⚫ |
| When there are no results for query and selecting Lucene as the query language, the message should display OpenSearch | 🟢 | ⚫ |
Details
🟢 The Modules//Events page should be displayed when the Lucene query language is selected in the search bar
Chrome - 🟢
🟢 When there are no results for query and selecting Lucene as the query language, the message should display OpenSearch
Chrome - 🟢
ℹ️ I have not tested the mentioned test related to the query in Lucene, because these don't apply to the proposed changes in the pull request.
yenienserrano
deleted the
fix-5284-when-the-search-bar-language-is-lucene-the-events-view-is-broken
branch
5 tasks
AlexRuiz7
pushed a commit
that referenced
this pull request
Mar 17, 2023
* Change href to opensearch.queryDSL.base * Change text, elasticsearch to opensearch * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is only for "OpenSearch dashboards", it changes code that was related to Elasticsearch in the OpenSearch Dashboards branch.
Issues Resolved
Lucenethe events view is broken #5284Evidence
Test
Preconditions
Navigate to 'Security events'
Click on 'Syntax options from search bar'
Change 'OpenSearch Dashboards Query Language' to 'off'
Test 1
Click on Events without data
The view "no results" has to be rendered
Test 2
Click on Events with data
The table has to be rendered
Test 1
Click on Events and do a search
The table has to be rendered with the search data.
Check List
yarn test:jest