Fix discover to panels preserve extra filters on filter-bar #459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team, this pull request fix a little non-desired behaviour whenever a user has a custom non-pinned filter on any overview/agent tab and goes to Discover sub tab then come back to Panels sub tab.
The trick here was to add a boolean variable to check if I'm on the same tab but come from Discover or if indeed I'm new for this tab. If
localChange
is true it means we are on that situation, otherwise it'll be false.Finally, and using
localChange
, we can decide what to do on the right way:Best regards,
Jesús