-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modules settings persistence between updates #4359
Conversation
…y file when changing the plugin version or revision - Migrated the existent host configuration in the registry file when changing the plugin version or revision instead of remove it when it was rebuilt. - Removed not necessary return statements - Removed not necessary try/catch block - Added some logs - Enhanced some log messages - Created tests for the migration registry file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test ✅
CR ✅
|
* fix(plugin-initialize): migrate the host configuration in the registry file when changing the plugin version or revision - Migrated the existent host configuration in the registry file when changing the plugin version or revision instead of remove it when it was rebuilt. - Removed not necessary return statements - Removed not necessary try/catch block - Added some logs - Enhanced some log messages - Created tests for the migration registry file * changelog: add PR entry * changelog: removed new line Co-authored-by: Álex <[email protected]> (cherry picked from commit 3e056c5)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.3-1.2-wzd 4.3-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.3-1.2-wzd
# Create a new branch
git switch --create backport-4359-to-4.3-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3e056c59a177bc332437d1503e4b26a3a65ae79e
# Push it to GitHub
git push --set-upstream origin backport-4359-to-4.3-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.3-1.2-wzd Then, create a pull request where the |
…4384) Fix modules settings persistence between updates (#4359) * fix(plugin-initialize): migrate the host configuration in the registry file when changing the plugin version or revision - Migrated the existent host configuration in the registry file when changing the plugin version or revision instead of remove it when it was rebuilt. - Removed not necessary return statements - Removed not necessary try/catch block - Added some logs - Enhanced some log messages - Created tests for the migration registry file * changelog: add PR entry * changelog: removed new line Co-authored-by: Álex <[email protected]> (cherry picked from commit 3e056c5) Co-authored-by: Antonio <[email protected]>
* fix(plugin-initialize): migrate the host configuration in the registry file when changing the plugin version or revision - Migrated the existent host configuration in the registry file when changing the plugin version or revision instead of remove it when it was rebuilt. - Removed not necessary return statements - Removed not necessary try/catch block - Added some logs - Enhanced some log messages - Created tests for the migration registry file * changelog: add PR entry * changelog: removed new line Co-authored-by: Álex <[email protected]> (cherry picked from commit 3e056c5)
…es (#4385) Fix modules settings persistence between updates (#4359) * fix(plugin-initialize): migrate the host configuration in the registry file when changing the plugin version or revision - Migrated the existent host configuration in the registry file when changing the plugin version or revision instead of remove it when it was rebuilt. - Removed not necessary return statements - Removed not necessary try/catch block - Added some logs - Enhanced some log messages - Created tests for the migration registry file * changelog: add PR entry * changelog: removed new line Co-authored-by: Álex <[email protected]> (cherry picked from commit 3e056c5)
Description
This PR fixes that the host extension configuration was lost when changing the installed plugin (changed version or revision) because the registry file was rebuilt with an empty configuration for the
hosts
field. Now, thehosts
configuration is kept and migrates the extension configuration when changing the installed plugin.Extension configuration migration:
Changes
plugin version or revision, instead of removing it when it was rebuilt.
Test
Manual
Automatic
A new test file was created. Run the test with: