Fixed searchbar suggest handler undefined input ref #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Rodriguez <[email protected]>
Signed-off-by: Federico Rodriguez <[email protected]>
matiasmoreno876
approved these changes
Apr 29, 2022
Machi3mfl
approved these changes
Apr 29, 2022
matiasmoreno876
deleted the
fix/searchbar-suggest-handler-undefined-input-ref-4105
branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for the issue #4105
The ruleset view and the rule files view share the same input, so the reference of the input does not trigger the useEffect and is lost. To fix this I added a possible pre-existing reference to the constructor of the suggestion component.
This base issue also causes another problem, because changing the view doesn't reset the input and keeps the previous search. When a previous field has a query it fails on the new view.
E.g.
