Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][Modules][Events] Fixed cell enhancement when the value is a sub technique #3944

Merged
merged 5 commits into from
Apr 6, 2022

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Apr 4, 2022

Description

This PR fixes the enhancement of the rule.mitre.id cell to support values of sub techniques.

Closes #3928.

Screenshots

image

Test

  • Go to Modules/MITRE ATT&CK/Events and see an alert that contains a rule.mitre.id with a sub technique, the value of sub technique should be a unique button. The button should open a flyout and display data of the sub technique.

@Desvelao Desvelao added the type/bug Bug issue label Apr 4, 2022
@Desvelao Desvelao self-assigned this Apr 4, 2022
@Desvelao Desvelao linked an issue Apr 4, 2022 that may be closed by this pull request
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✔️
CR: ✔️

image

@Desvelao Desvelao changed the title [FIX][Modules][Events] Fixed cell enhancement when the value is a subtechnique [FIX][Modules][Events] Fixed cell enhancement when the value is a sub technique Apr 6, 2022
@Desvelao Desvelao merged commit 08a1111 into 4.3-7.10 Apr 6, 2022
@Desvelao Desvelao deleted the fix/3928-buttons-link-mitre-id-subtechnique branch April 6, 2022 09:39
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Jest Test Coverage % values
Statements 4.04% ( 1476 / 36559 )
Branches 1.61% ( 459 / 28480 )
Functions 2.98% ( 266 / 8934 )
Lines 4.09% ( 1428 / 34951 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MITRE techniques are not correctly linked
3 participants