Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change format permissions in FIM inventory #3649

Merged
merged 13 commits into from
Nov 15, 2021
Merged

change format permissions in FIM inventory #3649

merged 13 commits into from
Nov 15, 2021

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Oct 13, 2021 •
edited by CPAlejandro
Loading

Description

The information is adapted to the new format

Issues Resolved

Format Windows permissions in FIM inventory #3370

Test

To test it you need an agent on windows with version 4.3 and enter FIM inventory and enter the details

  1. Go to Inventory Section of an agent
  • Given the browser is logged in the Wazuh kibana app and you have an Windows active agent
  • When the user navigate to Integrity Monitoring -> pin Windows agent -> enter in Inventory section -> click in some of the rows available -> Permissions
  • Then the permissions will appear like a JSON correctly

Check List

  • Change format of viewing permissions.

@yenienserrano yenienserrano mentioned this pull request Oct 13, 2021
Closed
@yenienserrano yenienserrano self-assigned this Oct 14, 2021
@yenienserrano yenienserrano added 4.3 type/enhancement Enhancement issue labels Oct 15, 2021
@yenienserrano yenienserrano linked an issue Oct 15, 2021 that may be closed by this pull request
Format Windows permissions in FIM inventory #3370
Closed
gabiwassan
gabiwassan suggested changes Oct 18, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
gabiwassan
gabiwassan approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabiwassan gabiwassan requested a review from a team October 21, 2021 15:24
Machi3mfl
Machi3mfl approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros
Copy link
Contributor

@yenienserrano please check if the detail from FIM / Events is updated too with this change.
image

@frankeros
Copy link
Contributor

It would be nice if the arrow to expand is on the right of the sub title instead of the bottom.

@CPAlejandro CPAlejandro merged commit e80dfc8 into 4.3-7.10 Nov 15, 2021
@CPAlejandro CPAlejandro deleted the enhancement/3370-format-windows-permissions-in-fim-inventory branch November 15, 2021 08:48
@github-actions
Copy link
Contributor

Jest Test Coverage % values
Statements 3.78% ( 1348 / 35653 )
Branches 1.45% ( 407 / 28064 )
Functions 2.58% ( 222 / 8601 )
Lines 3.83% ( 1305 / 34082 )

@MauGaP MauGaP mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabiwassan gabiwassan gabiwassan approved these changes

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@CPAlejandro CPAlejandro Awaiting requested review from CPAlejandro

Assignees

@yenienserrano yenienserrano

Labels
type/enhancement Enhancement issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Format Windows permissions in FIM inventory
5 participants
@yenienserrano @frankeros @Machi3mfl @gabiwassan @CPAlejandro