-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added vulnerabilities inventory that affect to an agent #3069
Added vulnerabilities inventory that affect to an agent #3069
Conversation
const filters = filtersToObject(this.state.filters); | ||
const filter = { | ||
...filters, | ||
limit: '15' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the limit is fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because is just the default value. The page size value can be selected within the table component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if the page size changes, the limit
variable continues on 15
, no?
this.showToast('success', 'Your download should begin automatically...', 3000); | ||
await exportCsv( | ||
'/vulnerability/' + this.props.agent.id, | ||
[{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this empty object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I forgot to deleted. I'll fix it right away
return ( | ||
<Fragment> | ||
<EuiAccordion | ||
id={id === undefined ? Math.random().toString() : `${id}_details`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. When the id
variable will be undefined
? The EuiAccordion
needs an id
prop?
initialColumns={[ | ||
'icon', | ||
'timestamp', | ||
// 'rule.mitre.id', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this field is not necessary, you could remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
componentWillUnmount() { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove if not used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested ✔️
LGTM! Great job 🎉
Hi team!
This adds the new vulnerabilities per agent view and it's details flyout.
Closes #3011