Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time service for IE and Safari Dates #1505

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

juankaromo
Copy link
Contributor

@juankaromo juankaromo commented Jun 4, 2019

Hi team,

This PR solves the Invalid date problem in some browsers like Internet Explorer and Safari. The problem was that we were removing the Zulu time identifier 'Z' from the date it arrived (to add the timezone of the browser) and that towards it becoming a date format not supported by some browsers. Now we remove this identifier splitting and joining the original data to create a supported formatted one.

This PR solves #1469

Regards.

@juankaromo juankaromo requested a review from jesusgn90 June 4, 2019 10:24
@juankaromo juankaromo self-assigned this Jun 4, 2019
@juankaromo juankaromo marked this pull request as ready for review June 4, 2019 15:22
@juankaromo juankaromo added the type/bug Bug issue label Jun 4, 2019
@jesusgn90 jesusgn90 merged commit f3e96dd into 3.10-7.1 Jun 5, 2019
@jesusgn90 jesusgn90 deleted the fix-time-service-ie-safari branch June 5, 2019 09:22
jesusgn90 pushed a commit that referenced this pull request Jun 6, 2019
jesusgn90 pushed a commit that referenced this pull request Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Bug issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants