Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve app logger #1373

Merged
merged 14 commits into from
Apr 15, 2019
Merged

Improve app logger #1373

merged 14 commits into from
Apr 15, 2019

Conversation

jesusgn90
Copy link
Contributor

@jesusgn90 jesusgn90 commented Apr 15, 2019

Hi team,

This PR implements #1332

Brief summary:

  • Implemented a new naming convention for log origin (module:method)
  • Split log into two levels: info (default) and debug, it's a new setting for config.yml
  • If the log level is info the app is now less verbose.
  • If the log level is debug the app is now much more verbose, it also adds logs for successfully executed methods and some other useful information for debugging.
  • The server side has been fully refactored regarding of log management.
  • Client-side currently doesn't need so much refactor regarding logs because most of the methods are passing through the server side. Further improvements will be done.

How to enable debug mode:

a. Edit config.yml file and enable it, then restart Kibana:

logs.level: debug

b. Edit your settings from the Wazuh app, then restart Kibana.

Regards

@jesusgn90 jesusgn90 marked this pull request as ready for review April 15, 2019 10:46
@jesusgn90 jesusgn90 mentioned this pull request Apr 15, 2019
4 tasks
@jesusgn90 jesusgn90 merged commit dd6cc10 into 3.9-6.7 Apr 15, 2019
@jesusgn90 jesusgn90 deleted the log-level branch April 15, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant