Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0-7.10 - Fix metrics are not updated after a bad request in search input #2830

Merged
merged 1 commit into from
Jan 27, 2021
Merged

4.0-7.10 - Fix metrics are not updated after a bad request in search input #2830

merged 1 commit into from
Jan 27, 2021

Conversation

Desvelao
Copy link
Member

Hi team, this PR resolves:

  • Fix the metrics are not updated after a bad request with a bad query in the search input

Closes #2822

@Desvelao Desvelao added the type/bug Bug issue label Jan 25, 2021
@Desvelao Desvelao added this to the Sprint 123 - WUI milestone Jan 25, 2021
@Desvelao Desvelao self-assigned this Jan 25, 2021
frankeros
frankeros approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@frankeros frankeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros linked an issue Jan 25, 2021 that may be closed by this pull request
Search resume fails to show after bad search input #2822
Closed
@pablomarga pablomarga self-requested a review January 27, 2021 12:29
gabiwassan
gabiwassan approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@gabiwassan gabiwassan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pablomarga
pablomarga approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@pablomarga pablomarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankeros frankeros merged commit 3120306 into 4.0-7.10 Jan 27, 2021
@frankeros frankeros deleted the fix/2822-metrics-bad-elasticsearch-request branch January 27, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablomarga pablomarga pablomarga approved these changes

@frankeros frankeros frankeros approved these changes

@gabiwassan gabiwassan gabiwassan approved these changes

Assignees

@Desvelao Desvelao

Labels
type/bug Bug issue
Projects
None yet
Milestone
Sprint 123 - WUI
Development

Successfully merging this pull request may close these issues.

Search resume fails to show after bad search input
4 participants
@Desvelao @gabiwassan @frankeros @pablomarga