-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline installation workflows use release packages instead of pre-release packages #161
Comments
Update reportA new input has been added to the workflow dispatch so that we can select between pre-release and staging. In addition, an environment variable has been created so that, if the workflow is being executed from a PR, the pre-release repository is selected by default and, if it has been executed manually, the variable selected in the input is used. For now this PR has been opened with the changes made so far in order to test the workflow when triggered by a PR. Testing 🧪Several tests are being done but the workflow fails in different occasions. Most likely it is not due to the change made in this issue, but more testing needs to be done to find out for sure where the error is coming from. |
Update reportThe issue with the job corresponding to Debian packages has been successfully resolved. However, regarding the CentOS job, since it runs inside a Docker container and requires Wazuh installations, it is likely that it will not function correctly. Further investigation into a solution is ongoing. A change that should be considered is to run these tests on two separate EC2 machines so that both tests are conducted under equal conditions. This approach would eliminate the need to execute the CentOS job in a Docker container, which might yield biased results due to being run in a container instead of on a dedicated machine. |
Update reportThe workflow has been redefined to use the allocator to test the offline installation. It will allow selecting the machines that can be used to execute the offline installation tests. Additionally, the various scripts used during testing have been fixed. Important These scripts have been tested on different operating systems. The only step remaining is to test them during the workflow execution to confirm their functionality. This PR has been opened with the changes made so far in order to test the workflow when triggered by a PR. |
Update reportErrors found with the new implementation:
Fixed 🟢: The problem was adding JWT permission to the workflow.
Fixed 🟢: This problem was due to a validation assigned a tag or branch that did not exist.
Fixed 🟢: Modify the Ansible installation to fix the problem. It occurs because Ansible is trying to format the stdout output using the YAML callback plugin, but it is unable to locate the required module to support this plugin.
We need to add permission to the role, for editing SG group.
|
Update reportAfter granting the necessary roles to change the Security Group (SG) to offline mode, an error was detected during the installation process:
This error occurs because the instances lack internet connectivity, preventing them from executing or downloading dependencies. Current Process:The Workflow executes the following steps for each instance specified in the inputs parameter:
After resolving the workflow-related issues, we discovered that the tests cannot be executed when the SG is modified to offline mode due to dependency and package download requirements.
Two major issues have been identified:
In conclusion, while we resolved the workflow issues and improved the steps, making the test fully functional would require extensive refactoring of all playbooks and the workflow structure. Given that this test will be deprecated in upcoming Wazuh versions, investing such significant effort in these modifications is not justified. |
Description
While working on #160, it was found that the offline installation workflow uses the release packages and not the pre-release packages, making it unable to run on versions that are still under development.
wazuh-installation-assistant/.github/actions/offline-installation/common.sh
Lines 98 to 101 in 084855c
We must add the
-d
option in the above command and check it works properly.The text was updated successfully, but these errors were encountered: