Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Command Manager to the new design #203

Closed
7 tasks done
Tracked by #27434 ...
AlexRuiz7 opened this issue Dec 27, 2024 · 0 comments · Fixed by #204 or #212
Closed
7 tasks done
Tracked by #27434 ...

Adapt Command Manager to the new design #203

AlexRuiz7 opened this issue Dec 27, 2024 · 0 comments · Fixed by #204 or #212
Assignees
Labels
level/task Task issue mvp Minimum Viable Product type/change Change performed in a resource or Wazuh Cloud environment

Comments

@AlexRuiz7
Copy link
Member

AlexRuiz7 commented Dec 27, 2024

Description

After completing the initial 5.0 MVP iteration, the initial design of the Command Manager plugin is going to be adapted due to incoming changes on the Server (see wazuh/wazuh#27434). The Command Manager will no longer be responsible for searching, preparing and sending the commands to the Server. It will be the Server who queries the Indexer for the commands, greatly simplifying the data flow.

Key changes include:

  • The Command Manager won't send commands to the Server. All code, settings, documentation and tests related must be removed as these won't be needed anymore.

  • The Command Manager still needs to implement a Job Scheduler job. This job's responsibility is to look for commands which have expired, updating their status to FAILURE. The job's schedule is configurable. The condition could be modeled as:

    if (order.delivery_timestamp < current_timestamp) {
      order.setStatus(Status.FAILURE);
      order.save();
    }

Functional requirements

  • Remove HttpClient module and delivery of commands.
  • Remove settings related to the delivery of commands.
    • m_api.uri
    • m_api.username
    • m_api.password
  • Adapt tests and documentation, removing what's necessary.

Plan

  • Remove code relates to the delivery of commands.
    • HttpClient.
    • Settings.
    • Deliver of orders from the Job Scheduler job.
    • Related tests.
  • Simplify SearchThread (job) to look for expired commands, updating their status.
  • Provide queries for the API #210

Related issues

@AlexRuiz7 AlexRuiz7 added level/task Task issue mvp Minimum Viable Product type/change Change performed in a resource or Wazuh Cloud environment labels Dec 27, 2024
@wazuhci wazuhci moved this to Backlog in XDR+SIEM/Release 5.0.0 Dec 27, 2024
@wazuhci wazuhci moved this from Backlog to In progress in XDR+SIEM/Release 5.0.0 Jan 7, 2025
@AlexRuiz7 AlexRuiz7 changed the title Adapt Command Manager to he new command pulling and distribution design Adapt Command Manager to the new design Jan 7, 2025
@wazuhci wazuhci moved this from In progress to Pending review in XDR+SIEM/Release 5.0.0 Jan 10, 2025
@wazuhci wazuhci moved this from Pending review to Pending final review in XDR+SIEM/Release 5.0.0 Jan 10, 2025
@wazuhci wazuhci moved this from Pending final review to Done in XDR+SIEM/Release 5.0.0 Jan 10, 2025
@mcasas993 mcasas993 linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level/task Task issue mvp Minimum Viable Product type/change Change performed in a resource or Wazuh Cloud environment
Projects
Status: Done
2 participants