Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom branding: add customization.enabled configuration #4506

Closed
8 tasks done
Tracked by #4392
asteriscos opened this issue Sep 13, 2022 · 1 comment · Fixed by #4507 or #4791
Closed
8 tasks done
Tracked by #4392

Custom branding: add customization.enabled configuration #4506

asteriscos opened this issue Sep 13, 2022 · 1 comment · Fixed by #4507 or #4791
Assignees
Labels
type/enhancement Enhancement issue

Comments

@asteriscos
Copy link
Member

asteriscos commented Sep 13, 2022

Description

The White-labeling epic #4392 has a new requirement to add the ability to switch on or off the app white-labeling configuration.

Setting Type description
customization.enabled boolean Enable or disable branding customizations.

This setting allows the users to easily enable or disable the custom branding. The custom assets the user may have uploaded are kept, so they can be used again anytime by only enabling back the custom branding.

Depends on:

Tasks

  • Add the new setting to the plugin settings definitions
  • Modify the behavior of the application to apply or not the custom settings depending on the status of the new setting
  • Add validation
    • Frontend
    • Backend
  • Test
    • Frontend
    • Backend
@asteriscos asteriscos added the type/enhancement Enhancement issue label Sep 13, 2022
@asteriscos asteriscos changed the title Add customization.enabled configuration Add customization.enabled configuration Sep 13, 2022
@asteriscos asteriscos changed the title Add customization.enabled configuration Add customization.enabled configuration Sep 13, 2022
@asteriscos asteriscos changed the title Add customization.enabled configuration Add customization.enabled configuration Sep 13, 2022
@asteriscos asteriscos moved this to Triage in Release 4.4.0 Sep 14, 2022
@asteriscos asteriscos moved this from Triage to In Progress in Release 4.4.0 Sep 14, 2022
@asteriscos asteriscos self-assigned this Sep 14, 2022
@asteriscos asteriscos linked a pull request Sep 14, 2022 that will close this issue
@AlexRuiz7 AlexRuiz7 changed the title Add customization.enabled configuration Custom branding: add customization.enabled configuration Sep 14, 2022
@AlexRuiz7 AlexRuiz7 moved this from In Progress to On Hold in Release 4.4.0 Sep 16, 2022
@vikman90 vikman90 added this to the Release 4.4.0 milestone Sep 26, 2022
@Desvelao Desvelao moved this from On Hold to In Review in Release 4.4.0 Oct 11, 2022
@AlexRuiz7
Copy link
Member

Why is #4426 a dependency?

Repository owner moved this from In Review to Done in Release 4.4.0 Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
No open projects
Status: Done
3 participants