Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review custom styles for Kibana 7.9.0 #4480

Closed
Tracked by #4160
AlexRuiz7 opened this issue Sep 9, 2022 · 2 comments · Fixed by #4491
Closed
Tracked by #4160

Review custom styles for Kibana 7.9.0 #4480

AlexRuiz7 opened this issue Sep 9, 2022 · 2 comments · Fixed by #4491
Assignees

Comments

@AlexRuiz7
Copy link
Member

AlexRuiz7 commented Sep 9, 2022

Description

Our source code contains custom styles for Kibana 7.9.0, introduced when the support for this version was added.

We need to check if OpenSearch Dashboards use any of these styles, in such case, we'll be overwritten them.

If not, the custom styles can be safely removed, at least for the OpenSearch / Wazuh Dashboard application, keeping them in the Kibana app just in case.

Strategy

  • Remove the custom styles in a dev environment and compare with the latest stable Wazuh Dashboard version in order to detect any changes on the layout or styling.
@AlexRuiz7 AlexRuiz7 changed the title Review custom styles for Kibana 7.9.0 for OSD 2.x Review custom styles for Kibana 7.9.0 Sep 9, 2022
@AlexRuiz7 AlexRuiz7 assigned AlexRuiz7 and yenienserrano and unassigned AlexRuiz7 Sep 9, 2022
@AlexRuiz7 AlexRuiz7 moved this to Triage in Release 4.4.0 Sep 9, 2022
@AlexRuiz7 AlexRuiz7 moved this from Triage to In Progress in Release 4.4.0 Sep 9, 2022
@yenienserrano
Copy link
Member

yenienserrano commented Sep 12, 2022

From what I could investigate I saw that in the archive there are many class names with references to Kibana that in Opensearch dashboard are changed to osd for example: kbnDocViewer change to osdDocViewer.

The other classes, for the most part, are in osd and have the same values.

From what I've been testing, these files can be deleted.

Screenshot without 7.9.0 styles

image

image

image

image

with 7.9.0 styles

image

image

image

image

@yenienserrano yenienserrano linked a pull request Sep 12, 2022 that will close this issue
@yenienserrano yenienserrano moved this from In Progress to In Review in Release 4.4.0 Sep 12, 2022
@Mayons95
Copy link
Contributor

TR: ✔️

Screencast.from.14-09-22.11.19.47.webm

@yenienserrano yenienserrano moved this from In Review to Done in Release 4.4.0 Sep 15, 2022
@AlexRuiz7 AlexRuiz7 reopened this Sep 16, 2022
@vikman90 vikman90 added this to the Release 4.4.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants