Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes after general review #1361

Closed
10 tasks done
juankaromo opened this issue Apr 10, 2019 · 5 comments
Closed
10 tasks done

Some fixes after general review #1361

juankaromo opened this issue Apr 10, 2019 · 5 comments
Assignees
Labels
type/enhancement Enhancement issue

Comments

@juankaromo
Copy link
Contributor

juankaromo commented Apr 10, 2019

After doing a global review of our apps, we have detected the following improvements that need to be implemented:

Priority

  • Change ColResize library to fix table resize behavior

Other issues

  • Expand the visualizations by clicking on the whole card header in Overview General, as it is only in agents.
  • The list of group agents has to be resizable and have custom columns.
  • The scroll in preview file of a group that is not agent.conf is broken, in addition, this container must fit all the possible height inside the view.
  • In the decoder details the regex comes out when we already have it on a separate card. Also, it is necessary to update the icons.
  • If in the APIs view I delete the last one I have a white box, however, if I enter the first time I do not.
  • In the agent search bar, the recycle bin should be replaced by an X and displayed only if there is content.
  • Node selector must not appear duplicated in ossec.conf editor view.
  • Add SCA regex fields in the checks table. Needs API implementation.
  • Filters for ruleset are broken if looking custom rules Filters for ruleset are broken if looking custom rules #1347

Regards.

@juankaromo juankaromo added the type/enhancement Enhancement issue label Apr 10, 2019
@juankaromo juankaromo self-assigned this Apr 10, 2019
@juankaromo juankaromo changed the title UI/UX minor fixes after general review Some fixes after general review Apr 10, 2019
@juankaromo
Copy link
Contributor Author

@juankaromo
Copy link
Contributor Author

juankaromo commented Apr 11, 2019

Update

The main task performed today was to the replacement of the colResize library with the jQuery resizable() method, to avoid wrong behaviors when resizing table columns, although it is necessary to review the behavior when expanding a column too much. On the other hand, the rest of the tasks of the issue have been implemented in its entirety. It remains to review the dashboards of Osquery.

@jesusgn90
Copy link
Contributor

Expand the visualizations by clicking on the whole card header in Overview General, as it is only in agents. Overview > General was the only one affected view, missing octrl. before expand(n) 1df0f7a

@jesusgn90 jesusgn90 self-assigned this Apr 12, 2019
@jesusgn90 jesusgn90 added this to the 15th week sprint milestone Apr 12, 2019
@juankaromo
Copy link
Contributor Author

The weird behavior when resizing tables with the new jQuery method was due to the euiTable--responsive class that was being applied to the tables. c2eb322

@juankaromo
Copy link
Contributor Author

Issue #1347 (Filters for ruleset are broken if looking custom rules) has been solved here 980eb55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

3 participants