Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent from being redirected to Overview once a Kibana restart is performed #1350

Closed
jesusgn90 opened this issue Apr 6, 2019 · 1 comment
Assignees
Labels
type/enhancement Enhancement issue

Comments

@jesusgn90
Copy link
Contributor

This behavior is expected, we were forcing it from a long time ago due to some resolve functions that were only applied if going to Overview controller, right now, I think there is no need to keep this behavior because we've improved a lot the routing system.

  1. Study if it's really needed right now
  2. If so, modify the needed logic so we don't need it anymore.

Regards

@jesusgn90
Copy link
Contributor Author

After some researching, we've concluded it's no longer needed to keep certain logic in the resolve methods (executed before each parent state). Time ago, those resolve methods were executed just in Overview controller, that's why we redirect the user to Overview when cookies were outdated, right now, it's no longer needed.

The PR #1378 deprecates that logic and removes the } else if { from settings wizzard resolve module. Also, some methods related to cookies management have been removed (unused now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement issue
Projects
None yet
Development

No branches or pull requests

1 participant