-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify API to get HIPAA and NIST 800 53 rule groups #386
Comments
Status update SummaryToday I have completed a draft implementation of the changes required to add new endpoints Tasks
DifficultiesUpdating Tests performedMocha tests are on hold until actual PendingMocha test |
Status update SummaryToday I have completed a full implementation of the changes required to add new endpoints Tasks
DifficultiesTests performedAdded <group>authentication_failed,pci_dss_10.2.4,pci_dss_10.2.5,hipaa_164.312.b,nist_800_53_AU.3,nist_800_53_IA.10</group>
Filters:
PendingMocha test |
Updated and run unit tests:
|
Mocha integration tests: Rules
GET/rules
✓ Request (278ms)
✓ Pagination (266ms)
✓ Retrieve all elements with limit=0 (259ms)
✓ Sort (269ms)
✓ Search (357ms)
✓ Filters: Invalid filter
✓ Filters: Invalid filter - Extra field
✓ Filters: status (266ms)
✓ Filters: group (292ms)
✓ Filters: level (1) (271ms)
✓ Filters: level (2) (374ms)
✓ Filters: path (277ms)
✓ Filters: file (265ms)
✓ Filters: pci (337ms)
✓ Filters: gdpr (265ms)
✓ Filters: hipaa (256ms)
✓ Filters: nist-800-53 (255ms)
GET/rules/groups
✓ Request (259ms)
✓ Pagination (258ms)
✓ Retrieve all elements with limit=0 (260ms)
✓ Sort (257ms)
✓ Search (259ms)
✓ Filters: Invalid filter
GET/rules/pci
✓ Request (259ms)
✓ Pagination (260ms)
✓ Retrieve all elements with limit=0 (259ms)
✓ Sort (258ms)
✓ Search (259ms)
✓ Filters: Invalid filter
GET/rules/gdpr
✓ Request (260ms)
✓ Pagination (262ms)
✓ Retrieve all elements with limit=0 (259ms)
✓ Sort (259ms)
✓ Search (259ms)
✓ Filters: Invalid filter
GET/rules/hipaa
✓ Request (260ms)
✓ Pagination (259ms)
✓ Retrieve all elements with limit=0 (258ms)
✓ Sort (263ms)
✓ Search (260ms)
✓ Filters: Invalid filter
GET/rules/nist-800-53
✓ Request (263ms)
✓ Pagination (261ms)
✓ Retrieve all elements with limit=0 (262ms)
✓ Sort (269ms)
✓ Search (260ms)
✓ Filters: Invalid filter
GET/rules/files
✓ Request (164ms)
✓ Pagination (165ms)
✓ Retrieve all elements with limit=0 (166ms)
✓ Sort (164ms)
✓ Search (165ms)
✓ Filters: Invalid filter
✓ Filters: Invalid filter - Extra field
✓ Filters: status (165ms)
✓ Filters: download (164ms)
GET/rules/:rule_id
✓ Request (256ms)
✓ Pagination (255ms)
✓ Retrieve all elements with limit=0 (256ms)
✓ Sort (257ms)
✓ Search (259ms)
✓ Filters: Invalid filter
✓ Params: Bad rule id
✓ Params: No rule (254ms)
64 passing (14s) |
Status update SummaryHi team, I have done further testing on the new Tasks
DifficultiesTests performed
Pending |
This issue requires the following issues to be closed in order to work:
Currently, there are a few endpoints used to list groups from several compliance standards:
GET /rules/gdpr
GET /rules/pci
To be consequent with the above, new endpoints should be added:
GET /rules/nist-800-53
GET /rules/hipaa
In addition, the following endpoints should be prepared to filter by
nist-800-53
andhipaa
accordingly to the new response:Subtasks:
The text was updated successfully, but these errors were encountered: