Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue detected by ckeditor #95

Closed
zsoltjanes opened this issue Jul 2, 2024 · 8 comments
Closed

Security issue detected by ckeditor #95

zsoltjanes opened this issue Jul 2, 2024 · 8 comments

Comments

@zsoltjanes
Copy link

Hi! Can you please take a look about this message,which appeared to me from today on the ckeditor.

image

@Hirannuwanpriya
Copy link

I'm also getting the Same Warning.

@Hirannuwanpriya
Copy link

Hirannuwanpriya commented Jul 3, 2024

For the time being, I added 'versionCheck' => false, to the Nova config file, and the warning has disappeared.

@adriandmitroca
Copy link
Contributor

Adding 'versionCheck' => false to config/nova/ckeditor-field.php didn't work for me. I also don't see any code references to that property.

@zsoltjanes
Copy link
Author

Adding 'versionCheck' => false to config/nova/ckeditor-field.php didn't work for me. I also don't see any code references to that property.

Add it to the options section

@adriandmitroca
Copy link
Contributor

Oh nice, thanks!

@PieterCappelle
Copy link

Came here for the same issue :-) (thanks for the solution!)

@chrispelzer
Copy link
Member

chrispelzer commented Jul 5, 2024

Hey all!

I just released v1.4.0 due to it defaulting the version checking to be false by default. I didn't want to check people who have been using the LTS off guard.

Thanks to @adriandmitroca for the PR. I also added some information to the top of the README.md about what this is and if you wish to get LTS from CKEditor4.

It's out of my hands as all this package is providing the integration with Laravel Nova.

The best thing would be to move to CKEditor5. I've been exploring it in my projects and these days I can't tell the difference between it and CKeditor4 anymore. The thing that I really needed CKEditor4 was the ability to edit source, at the start of CKEditor5 that wasn't the possible.

There is a CKEditor5 package for Laravel Nova at https://github.com/mostafaznv/nova-ckeditor which last was updated 2 months, so they are still going strong with their CKEditor5 package.

@haidong2099
Copy link

in file : Your_Src_Code/config/nova.php
Add this config

'ckeditor-field' => [
    'options' => [
        'versionCheck' => false,
    ],
],

];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants