Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Action and Query imports #914

Closed
sodic opened this issue Dec 28, 2022 · 1 comment
Closed

Fix Action and Query imports #914

sodic opened this issue Dec 28, 2022 · 1 comment
Labels
bug Something isn't working compiler dx

Comments

@sodic
Copy link
Contributor

sodic commented Dec 28, 2022

When importing an Action or a Query (from @wasp), the IDE does not recognize their type.

If I change the default import into a named import, it does recognize it.

We should explore why this happens and probably change all our default exports into named exports (in both the code and the docs).

The detailed explanation is given in #546. Using default exports wasn't too big of a deal so far, but since it's now began causing noticeable problems with IDE support, we should definitely do something about them.
@sodic sodic mentioned this issue Dec 28, 2022
Open
@sodic sodic added enhancement New feature or request dx compiler bug Something isn't working and removed enhancement New feature or request labels Jan 7, 2023
@infomiho infomiho self-assigned this Jan 13, 2023
@infomiho infomiho removed their assignment Feb 21, 2023
@sodic
Copy link
Contributor Author

sodic commented May 10, 2024

Restructuring (v0.12.0) took care of this problem. Relevant PR: #1696

@sodic sodic closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compiler dx
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Martinsos @infomiho @sodic