Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ext/ dir with more structured organization of code (client, server, iso/shared)? #522

Closed
Martinsos opened this issue Mar 24, 2022 · 1 comment · Fixed by #753
Closed
Labels
enhancement New feature or request hm Requires more thought idea Something to consider language

Comments

@Martinsos
Copy link
Member

The idea is to split ext/ into client/, server/ and iso/. So then we would copy client/ and iso/ to client, and server/ and iso/ to server. That actually sounds like a good solution for the problem we currently have, which is that we copy all the files everywhere and then get warnings and what not. It also makes it clearer which code is nodejs and which is just javascript.
Naming might be better though, e.g. it could be shared/ instead of iso/. Or maybe names could be js/, nodejs/ and iso/ - but that is maybe too technical.

As mentioned by @shayneczyzewski , Meteor is doing smth similar:

Yep, I do indeed remember client/ and server/ having special meaning in Meteor. I think anything else was loaded in both, and lib/ had some special load order I think. You also got Meteor.isClient and Meteor.isServer to help you do the right thing in files loaded in both contexts.

@Martinsos Martinsos added enhancement New feature or request idea Something to consider hm Requires more thought language labels Mar 24, 2022
@Martinsos Martinsos changed the title Replace ext/ dir with more structured organization of code (client, server, iso/shared) Replace ext/ dir with more structured organization of code (client, server, iso/shared)? Mar 24, 2022
@Martinsos
Copy link
Member Author

We also got feedback that ext/ is a bit of a weird name. Makes sense! We should probably name it somehow differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hm Requires more thought idea Something to consider language
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant