Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how our file watching works #1844

Open
sodic opened this issue Mar 1, 2024 · 6 comments
Open

Investigate how our file watching works #1844

sodic opened this issue Mar 1, 2024 · 6 comments

Comments

@sodic
Copy link
Contributor

sodic commented Mar 1, 2024

With Wasp 0.12.0 and the restructuring (#1688), we've removed the constraint of separating server files from client files.

We should investigate the impact this had on our watching procedures and hot reloads.

Goals:

  • The server rebuilds only on changes that affect the server framework code.
  • The SDK rebuilds only on changes that affect the SDK code.
  • The web app rebuilds only on changes that affect the web-app framework code.

Questions, on each change, what does:

  • Nodemon watch?
  • TSC compile (in SDK)?
  • Rollup rebuild?
  • Vite watch?
  • Vite rebuild?

Relevant context:

Relevant todo in the code:

-- Filip: We no longer want separation between client and server code

@sodic sodic added question Further information is requested research and removed question Further information is requested labels Mar 5, 2024
@Martinsos
Copy link
Member

We also seem to be having an issue with too many files being watched with the recent projects, check out this issue: #1919 .

This might be because we have some files being watched redundantly.

There are commands that track how many files are watched by which process, so we should se that to observe what is happening.

@napon
Copy link

napon commented Aug 22, 2024

I'm running into this issue in my project. Let me know if you need me to share any logs to help debug the issue further!

@sodic
Copy link
Contributor Author

sodic commented Aug 22, 2024

Hi @napon, thanks for reporting!

Just to ensure I got it right, you're talking about "too many files being watched" issue?

@napon
Copy link

napon commented Aug 22, 2024

Yes that's right

@sodic
Copy link
Contributor Author

sodic commented Aug 23, 2024

Hmm, I gotta admit I'm not familiar enough with the tools used to debug these kinds of issues, so I wouldn't know what to ask for.

@napon Any chance you'd be ready to share your project with me and let me play around with debugging it locally?

@infomiho
Copy link
Contributor

Related issue: #1843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants