Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Wasm multi-memory proposal #1191

Merged
merged 44 commits into from
Sep 24, 2024
Merged

Conversation

Robbepop
Copy link
Member

Closes #776.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

Attention: Patch coverage is 88.00623% with 77 lines in your changes missing coverage. Please review.

Project coverage is 80.79%. Comparing base (1d98b71) to head (48292e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/executor/instrs/store.rs 60.00% 18 Missing ⚠️
crates/wasmi/src/engine/executor/instrs.rs 84.15% 16 Missing ⚠️
crates/wasmi/src/engine/translator/visit.rs 65.78% 13 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/load.rs 68.75% 10 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/memory.rs 83.33% 9 Missing ⚠️
crates/ir/src/immeditate.rs 50.00% 3 Missing ⚠️
crates/wasmi/src/engine/translator/mod.rs 97.41% 3 Missing ⚠️
...rates/wasmi/src/engine/translator/tests/op/load.rs 95.91% 2 Missing ⚠️
crates/wasmi/src/engine/config.rs 75.00% 1 Missing ⚠️
.../wasmi/src/engine/translator/tests/op/store/mod.rs 95.23% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
+ Coverage   80.67%   80.79%   +0.11%     
==========================================
  Files         300      300              
  Lines       24523    24873     +350     
==========================================
+ Hits        19785    20096     +311     
- Misses       4738     4777      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop marked this pull request as draft September 23, 2024 21:32
@Robbepop Robbepop marked this pull request as ready for review September 24, 2024 12:06
@Robbepop Robbepop merged commit 0b39af8 into main Sep 24, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-impl-multi-memory-proposal branch September 24, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Wasm multi-memory proposal
1 participant