Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: try latest memfs #182

Closed
corwin-of-amber opened this issue Jan 15, 2020 · 2 comments · Fixed by #184
Closed

Suggestion: try latest memfs #182

corwin-of-amber opened this issue Jan 15, 2020 · 2 comments · Fixed by #184

Comments

@corwin-of-amber
Copy link
Contributor

Greetings @torch2424 @syrusakbary,

I pushed the fix by Syrus regarding open(..., O_DIRECTORY) to memfs's upstream repo (streamich/memfs#495) and it's now published as [email protected].
I tried upgrading and it works smoothly, of course my testing is pretty superficial so perhaps you want to try it yourself.

If it works, the dependency on the fork (https://github.com/torch2424/memfs) can be eliminated.

@syrusakbary
Copy link
Member

Thanks for the ping @corwin-of-amber!

@torch2424
Copy link

@corwin-of-amber Again, cannot express how cool that is that you contributed this upstream, and gave us a shout out for it! 😄

Yes, I'll pin this issue in an open tab so I wont forget, and try to update this after our next launch tommorrow. Thanks again! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants