Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.6.x is EOL and no longer supported. #304

Closed
major0 opened this issue Feb 6, 2023 · 7 comments · Fixed by #306
Closed

Python 3.6.x is EOL and no longer supported. #304

major0 opened this issue Feb 6, 2023 · 7 comments · Fixed by #306
Assignees
Labels
Priority: High Type: Bug Something isn't working

Comments

@major0
Copy link

major0 commented Feb 6, 2023

Describe the bug
Python 3.6 is end-of-life and appears to be breaking installation of salt-lint?

https://endoflife.date/python

An unexpected error has occurred: CalledProcessError: command: ('/home/runner/.cache/pre-commit/reporr1pgmpm/py_env-python3/bin/python', '-mpip', 'install', '.')
return code: 1
stdout:
    Processing /home/runner/.cache/pre-commit/reporr1pgmpm
      Preparing metadata (setup.py): started
      Preparing metadata (setup.py): finished with status 'error'
    
stderr:
      error: subprocess-exited-with-error
      
      × python setup.py egg_info did not run successfully.
      │ exit code: 1
      ╰─> [1 lines of output]
          error in salt-lint setup command: 'python_requires' must be a string containing valid version specifiers; Invalid specifier: '>=3.6.*'
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
    error: metadata-generation-failed
    
    × Encountered error while generating package metadata.
    ╰─> See above for output.
    
    note: This is an issue with the package mentioned above, not pip.
    hint: See above for details.
    
Check the log at /home/runner/.cache/pre-commit/pre-commit.log
@major0 major0 added the Type: Bug Something isn't working label Feb 6, 2023
@rreuvekamp
Copy link

Invalid specifier: '>=3.6.*'

This seems key. We're also effected, even though we're not running 3.6 (at least, I hope)

@major0
Copy link
Author

major0 commented Feb 7, 2023

Yah, the culprit looks to be here: https://github.com/warpnet/salt-lint/blob/main/setup.py#L61

@edggoncalves
Copy link

After forking the repository and replacing that with 3.8, I still observe the same behavior.

@czyszCTDS
Copy link

Noticed this bug in our CI pipeline today and tracked it as an intended change from packaging: pypa/packaging#645

The fix is probably to drop the *: python_requires='>=3.6'

@roaldnefs
Copy link
Member

Thanks @czyszCTDS your suggestion. Let's give you suggestion a try, removing the wildecard (*) shouldn't have any impact on the accepted version numbers as both >=3.6 and >=3.6.* should be equal.

@roaldnefs
Copy link
Member

The updated python_requires definition has been released in v0.9.2.

@czyszCTDS
Copy link

Thank you! I can confirm the new version installs properly in our CI environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants