Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUP: #64 - Subshells don't work correctly #1012

Closed
thomasheartman opened this issue Apr 11, 2022 · 2 comments
Closed

DUP: #64 - Subshells don't work correctly #1012

thomasheartman opened this issue Apr 11, 2022 · 2 comments

Comments

@thomasheartman
Copy link

Discord username (optional)

No response

Describe the bug

When launching subshells (for instance by running `bash`, `zsh` or `fish`), all of Warp's fancy features disappear and you're dropped into a bog standard shell environment.

To Reproduce

Steps to reproduce:

  1. Open Warp
  2. Run bash

Expected behaviour

I'd expect Warp to adapt to the new shell, keeping the command separation and everything working as usual.

Screenshots

Screenshot using the default zsh shell with warp (running with all features):

image

After running zsh and launching a subshell:

image

Operating System

MacOS

OS Version

11.5.1

Additional context

First off: thank you all very much for a great product! I think it's a big step up in a lot of respects and I'm very curious to see where it goes from here!

Regarding the actual issue:

I use a Nix setup on my machine, so to start shells, I use the `nix-shell` command (both for my main environment and for project-specific shells). Sadly, this means that I lose all the fancy features that Warp provides when using shells with all the commands that I need for my workflow.

Admittedly, the Nix setup on my Mac is pretty poor, so that may be part of the problem, but I'd also expect Warp to handle subshells regardless.

I expect that (part of) the reason this happens is that when you start a new shell, the shell becomes a long-running process, so Warp probably just lets this process run as it would in any other terminal. I don't know if there's a good way around this or if Warp can recognize these commands in any way (or if it's desirable for most people). Maybe Warp could expose a user-editable list of commands that spawn new shells and that Warp should hook into somehow?
@dev4joel
Copy link

Duplicate of #64

@thomasheartman
Copy link
Author

Thanks! I tried searching for similar issues, but didn't find that one 😅 Feel free to close this (unless you'd rather keep it open?) ☺️

@elviskahoro elviskahoro changed the title Subshells don't work correctly DUP: #64 - Subshells don't work correctly Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants