Fix hardcoded public key auth negotiation #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authentication using rsa public keys were incorrectly hardcoded to use `ssh-rsa`, i.e., SHA1. This led to public keys set-up to use `rsa-sha2-256` or `rsa-sha2-512` falling back to `ssh-rsa` and being rejected by modern ssh servers that configured not to support SHA1 by default. The solution derives the hash name from the public key instead of hardcoding it.
|
Thank you! @all-contributors please add @tomknig for code |
|
I've put up a pull request to add @tomknig! 🎉 |
Eugeny
pushed a commit
that referenced
this pull request
Jun 2, 2024
Adds @tomknig as a contributor for code. This was requested by Eugeny [in this comment](#294 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
Thanks @Eugeny! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication using RSA public keys was incorrectly hardcoded to use
ssh-rsa, i.e., SHA1. This led to public keys set up to usersa-sha2-256orrsa-sha2-512falling back tossh-rsaand being rejected by modern SSH servers that are configured not to support SHA1 by default.The solution derives the hash name from the public key instead of hardcoding it.