Allow per-location directives push_stream_max_messages_stored and push_stream_message_ttl #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
您的信已收到，我将尽快给您答复
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use
push_stream_max_messages_storedandpush_stream_message_ttlinserverandlocation.One thing this PR does not handle is taking into account the above-mentioned settings in regard to EVENT messages for the channels. Those will always use the values configured in
httpscope.Mind the difference between
push_stream_max_messages_stored_per_channel(httpscope) andpush_stream_max_messages_stored(serverandlocationscope).The
push_stream_message_ttlis the same naming in all three scopes.fixes #158