fix(weave_query): prevent table state loss when encountering a new logged column

[domphan-wandb]

Description

• Fixes WB-17336

There was a user experience issue causing a table's state (derived columns, sorting, etc) to be wiped when the user logged an additional column with their table in a subsequent run.

Initially I couldn't reproduce it, but realized the issue only occurs after the first new column is added-- subsequent added columns did not reset the table state.

Root cause: the typeShapesMatch util function (only used to determine if tableState should be migrated) does not handle the case of a type being a union<typedDict, typedDict> and the toType being a typedDict where the union members match the property types of the toType's typedDict.

This fix adds a check when the toType is a typedDict and the type is a union<typedDict>. It uses the existing typedDict checking logic to confirm all the members of the union are compatible. I also refactored some of the conditional checks to make it a bit more readable.

I also need to note that the existing behavior did not correctly check the case where two unions are passed in. It will by default return true. In order to reduce the chances of shipping a regression, I've left that untouched and left a comment in the code.

Screen.Recording.2024-11-22.at.11.48.37.AM.mov

Testing

• Unit tests
• Local dev QA

[circle-job-mirror]

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f4e257bebe88c77b771338cd1c8a9a634e3542c8