fix(weave_query): Ensure newVars are passed in when expanding a panel op #3059
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domphan-wandb
changed the title
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=2f836a25f5f39722eb0db3e5de49ee59f5c118cb |
domphan-wandb
force-pushed
the
dom/fix-table-panel-op
branch
from
ff0503f
to
15853b8
Compare
shawnlewis
approved these changes
Nov 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The panel op,
.table()crashes the panel when it is used in the following manner:runs.summary["table"].run.tableruns.summary["table"].table.run.tableThe error occurs from a var node being sent to the query engine service. After much debugging and pairing on this with @shawnlewis, we determined that the
useExpandedNodehook was not receiving the frame with therunsnode, so the solution was to pass innewVarsfrom theusePanelExpressionStatehook.No longer crashes:
Testing
How was this PR tested?