Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request | Support ClickHouse and Kafka passwords as secret key variables #307

Open
vijay-wandb opened this issue Nov 20, 2024 · 0 comments · May be fixed by wandb/helm-charts#267
Open
Assignees
Labels
Priority-P0 Critical priority designation

Comments

@vijay-wandb
Copy link

vijay-wandb commented Nov 20, 2024

Support ClickHouse and Kafka passwords as secret key variables - use the same technique as adopted for license, mysql and bucket credentials.

Current structure uses hardcoded passwords

    install: false
    host: ""
    port: 8443
    password: "fake"
    database: "weave_trace_db"
    user: "default"
  kafka:
    # The following values are anchored here, and referenced by alias later for
    # the kafka dependency chart.
    user: &kafkaUser "wandb"
    password: &kafkaPassword "wandb"
    brokerHost: ""
    brokerPort: 9092
    runUpdatesShadowTopic: ""
    # This value will only apply upon initial topic creation.
    # If the topic already exists then changing the number of partitions is not possible.
    runUpdatesShadowNumPartitions: 12
# It is *strongly* recommended to supply passwords yourself for production installs.
kafka:
  install: false
  controller:
    persistence:
      size: 30Gi
  sasl:
    interbroker:
      password: "inter-broker"
    controller:
      password: "controller-pw"
    # The client usernames and passwords are alias references from the global values section at the beginning of this file.
    # Please update the values there to ensure proper propagation to the application
    client:
      users:
        - *kafkaUser
      passwords: *kafkaPassword
@vijay-wandb vijay-wandb self-assigned this Nov 20, 2024
@vijay-wandb vijay-wandb added the Priority-P2 Medium priority for the request label Nov 20, 2024
@abhinavg6 abhinavg6 added Priority-P0 Critical priority designation and removed Priority-P2 Medium priority for the request labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority-P0 Critical priority designation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants