Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type declarations #16

Open
eheikes opened this issue Oct 18, 2019 · 3 comments
Open

Type declarations #16

eheikes opened this issue Oct 18, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@eheikes
Copy link
Contributor

eheikes commented Oct 18, 2019

We're consuming @webauthn/server in a TypeScript-based project. Is there interest in adding and maintaining type declarations (a .d.ts file) for that API in this project, or should we add them to DefinitelyTyped and keep them separate?
@Kmaschta Kmaschta added the enhancement New feature or request label Oct 28, 2019
@Kmaschta
Copy link
Contributor

Both would be a great addition!
Ideally, it's better to include that in the module itself. Contributions are more than welcome!

@P4sca1
Copy link

P4sca1 commented Nov 4, 2019

How about writing the library in typescript? This avoids the hassle of manually keeping the type declarations in sync and comes with the benefits of writing TypeScript.

@eheikes
Copy link
Contributor Author

eheikes commented Nov 5, 2019

How about writing the library in typescript? This avoids the hassle of manually keeping the type declarations in sync and comes with the benefits of writing TypeScript.

Totally agree. The downside is that it adds friction for non-TS developers who want to work on the project, which the maintainers may not want.

@MasterKale MasterKale mentioned this issue Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eheikes @Kmaschta @P4sca1