Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for wallabyTest.ts #38

Open
mwymann opened this issue Nov 29, 2018 · 1 comment
Open

Update docs for wallabyTest.ts #38

mwymann opened this issue Nov 29, 2018 · 1 comment

Comments

@mwymann
Copy link

mwymann commented Nov 29, 2018

I had an issue starting wallaby:
Uncaught ReferenceError: Zone is not defined

After hours of research I found the solution coincidentally.
The imports in wallabyTest.ts are dependent on each other, so order really matters.
import './polyfills';
import 'core-js/es7/reflect';
import 'zone.js/dist/zone-testing';
// imports of angular testing modules...

Unfortunately I had a personal setting in VS Code:
"editor.codeActionsOnSave": {
"source.organizeImports": true
}
So everytime I saved the file the order of imports changed and wallaby crashed.

Maybe you could update your docs with a hint on this... ;-)

@ArtemGovorov
Copy link
Member

Thanks for the note! I'd also report the issue to VS Code team as it doesn't seem to be a correct behaviour to change the order of the imports where the order matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants