-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessarily passing cleartext URLs of all pages visited to server #204
Labels
Comments
Not yet. |
Ok perfect. Will the |
It'll be listed in the how to upgrade, see wallabag/wallabag#4361 (comment) |
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The "Indicate if page already saved" option is expected to make requests to your Wallabag server for every URL you visit, so it can check whether that URL is already saved. However, it currently uses the
url
query parameter to pass these URLs up as cleartext, and it doesn't need to.The /api/entries/exists endpoint can instead be passed a
hashed_url
parameter, which is the SHA-1 hash of a URL and can also indicate whether a URL matching that hash exists on the server. Wallabagger should use this parameter instead, to avoid potentially leaking every URL you ever visit.I don't know which versions of Wallabag support the
hashed_url
parameter, so it may be necessary to maintain support for cleartext checks as well. But makinghashed_url
available as an alternative option is certainly viable.The text was updated successfully, but these errors were encountered: