Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using RcppSimdJson, jsonify, or yyjsonr instead of jsonlite #48

Open
JosiahParry opened this issue May 5, 2024 · 1 comment

Comments

@JosiahParry
Copy link

I noticed that you are using jsonlite::fromJSON to parse fairly large results. From personal experience and benchmarks, jsonlite is one of the slowest packages available for this task. If performance is a goal of this package, I would consider exploring the packages RcppSimdJson & yyjsonr for parsing JSON and jsonify for making json. Simply replacing jsonlite with those dependencies can result in a massive speed up of your code.

@walkerke
Copy link
Owner

walkerke commented May 5, 2024

Appreciate the suggestion! I think that's something to consider if I find the time. We explored that a few months ago (see #39) but it led to breakages in the code, so I ended up tabling that for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants