Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output format for the data download #296

Closed
antagomir opened this issue Jul 2, 2023 · 3 comments
Closed

Output format for the data download #296

antagomir opened this issue Jul 2, 2023 · 3 comments
Assignees

Comments

@antagomir
Copy link

Is your feature request related to a problem? Please describe.

Downstream analyses could benefit from organizing the downloaded taxonomic and functional profiles into a standard data container instead of a list when this is possible.

Describe the solution you'd like

Instead of a list of (Tree)SE objects, the curatedMetagenomicData could return a MultiAssayExperiment object, or use altExp slots to combine the interlinked taxonomic profiles and functional predictions. This could be provided an option that the user can choose for the returned output data format, even if this is not applicable to all downloads combinations in general.

Describe alternatives you've considered

At the moment, the individual (Tree)SE objects can be combined manually into a single (Tree)SE or MAE after the download.

@lwaldron
Copy link
Member

lwaldron commented Jul 3, 2023

Using the altExp slots for multiple data types of the same dataset would be reasonable, and would also avoid situations like #295. altExp seems preferable to MultiAssayExperiment in this case because it's the simplest representation that the data can fit into.

However since this would be an API-breaking change, it should either go through a deprecation cycle or be added as optional functionality. I think I would be more inclined to add a helper function or documentation of how to do this rather than breaking the existing API, but open to comments about how an API change would benefit downstream analysis.

@antagomir
Copy link
Author

The benefit from adding it directly to the function (API) is that the extra step of creating the altExps can be avoided and this would simplify data retrieval. If it could be added as an optional functionality, the API should still work for the current use cases. If this is not feasible to implement, then a helper function (or documentation) could be handy.

@schifferl
Copy link
Collaborator

I think this feature is too specific for curatedMetagenomicData and will not be added.

Feel free to implement a DIY solution, but the package will remain broadly focused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants