Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Received a broken close frame containing a reserved status code. #807

Closed
teacoat opened this issue Jan 3, 2022 · 7 comments
Closed

Received a broken close frame containing a reserved status code. #807

teacoat opened this issue Jan 3, 2022 · 7 comments

Comments

@teacoat
Copy link

teacoat commented Jan 3, 2022

Occasionally will get this error:

Got it once on Jan 1, 2022 at 12:55am EST
image

Just got it again Jan 2, 2022 at 9:03pm EST
image

edit:
Got it again Jan 3, 2:33pm EST
image

Using js-waku

@D4nte
Copy link
Contributor

D4nte commented Jan 5, 2022

Looking at the websockify logs for the same instance, I can see

code 405, message Method Not Allowed

https://kibana.infra.status.im/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:'2022-01-01T05:30:00.000Z',to:'2022-01-01T06:00:00.000Z'))&_a=(columns:!(message,host,syslogtag),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:d6db7610-60fd-11e9-98fa-2f101d13f938,key:syslogtag,negate:!f,params:(query:docker%2Fwebsockify),type:phrase),query:(match_phrase:(syslogtag:docker%2Fwebsockify)))),index:d6db7610-60fd-11e9-98fa-2f101d13f938,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))

For the 9:03 I can see:

https://kibana.infra.status.im/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:'2022-01-02T04:00:00.000Z',to:'2022-01-02T04:05:00.000Z'))&_a=(columns:!(message,host,syslogtag),filters:!(('$state':(store:appState),meta:(alias:!n,disabled:!f,index:d6db7610-60fd-11e9-98fa-2f101d13f938,key:syslogtag,negate:!f,params:(query:docker%2Fwebsockify),type:phrase),query:(match_phrase:(syslogtag:docker%2Fwebsockify)))),index:d6db7610-60fd-11e9-98fa-2f101d13f938,interval:auto,query:(language:kuery,query:''),sort:!(!('@timestamp',desc)))

Jan 2, 2022 @ 04:00:44.269 - [02/Jan/2022 04:00:44] code 405, message Method Not Allowed
...
Jan 2, 2022 @ 04:00:44.219 - - [02/Jan/2022 04:00:44] code 405, message Method Not Allowed
...
Jan 2, 2022 @ 04:03:47.374185.100.87.136 - - [02/Jan/2022 04:03:47] code 501, message Unsupported method ('POST')
...
Jan 2, 2022 @ 04:03:57.515147.135.62.68 - - [02/Jan/2022 04:03:57] code 501, message Unsupported method ('PUT')

@teacoat how exact are the times you provided?

@teacoat
Copy link
Author

teacoat commented Jan 5, 2022

@teacoat how exact are the times you provided?

may be off by a min or two, i can try to get a more specific time next time it pops up

@oskarth
Copy link
Contributor

oskarth commented Jan 10, 2022

Considering native WS support is on its way in the next release, we can probably deprioritize this for now.

@oskarth
Copy link
Contributor

oskarth commented Jan 10, 2022

See if this fixes it #808

@jm-clius
Copy link
Contributor

@D4nte, any feedback on native websocket performance after the release? According to me things are stable now and issues related to websockify can probably be closed (once we disable websockify).

@D4nte
Copy link
Contributor

D4nte commented Jun 23, 2022

@D4nte, any feedback on native websocket performance after the release? According to me things are stable now and issues related to websockify can probably be closed (once we disable websockify).

I haven't checked yet. I want to finish js-waku upgrade to latest libp2p library first waku-org/js-waku#803 as it contains a stream disconnection bug fix libp2p/js-libp2p#1221 which I hope will help with connection stability.

Once done, I can do more thorough testing of nim-websocket integration in nwaku.

@jm-clius
Copy link
Contributor

jm-clius commented Jan 6, 2023

We are now using native websockets. Closing.

@jm-clius jm-clius closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants