Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Encrypting the content of the rln credential file #1114

Closed
1 task done
staheri14 opened this issue Sep 1, 2022 · 1 comment
Closed
1 task done

feat: Encrypting the content of the rln credential file #1114

staheri14 opened this issue Sep 1, 2022 · 1 comment

Comments

@staheri14
Copy link
Contributor

staheri14 commented Sep 1, 2022

Problem

The rln credential file contains privacy-sensitive membership information of the user and should be encrypted. Currently, it is a plaintext file. This would not cause any serious issue as long as we are running on the Ethereum testnet, but when moving to the mainnet then membership credentials will have actual financial value.
Relevant part of the code https://github.com/status-im/nwaku/blob/982fb08c7735c131ecacc801f21ac56d15286567/waku/v2/protocol/waku_rln_relay/waku_rln_relay_utils.nim#L1131

Suggested solution

The rln credentials should be encrypted before being written to the rlnCredentials.txt file. A potential solution is to use Keystore similar to how it is used by nimbus.

Alternatives considered

NA

Additional context

Acceptance criteria

  • At a high level, the rlnCredentials.txt should only contain encrypted credentials but not plain ones. The decryption power should be given to the user to unlock the file when needed. The use of Keystore is one way to achieve so.
@staheri14 staheri14 added the track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications label Sep 1, 2022
@jm-clius jm-clius removed this from Waku Sep 2, 2022
@staheri14 staheri14 moved this to Later/Icebox in Vac Research Sep 13, 2022
@staheri14 staheri14 moved this from Later/Icebox to Next/Backlog in Vac Research Oct 14, 2022
@rymnc rymnc moved this from Next/Backlog to Later/Icebox in Vac Research Jan 19, 2023
@rymnc rymnc added track:rlnp2p and removed track:rln RLN Track (Secure Messaging/Applied ZK), e.g. relay and applications labels Jan 19, 2023
@rymnc
Copy link
Contributor

rymnc commented Feb 28, 2023

Addressed with the usage of waku keystore in #1466

@rymnc rymnc closed this as completed Feb 28, 2023
@github-project-automation github-project-automation bot moved this from Later/Icebox to Done in Vac Research Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants