feat!: upgrade to [email protected] #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
Apart from the There is still one test failing for |
weboko
commented
Jun 20, 2023
| ); | ||
| return tags; | ||
| try { | ||
| const peer = await this.libp2p.peerStore.get(peerId); |
There was a problem hiding this comment.
context: Now all methods on PersistentPeerStore that libp2p uses are throwing so it is up to us how we handle that.
weboko
commented
Jun 20, 2023
weboko
commented
Jun 20, 2023
| ...pubsubService, | ||
| ...options?.services, | ||
| }, | ||
| }) as any as Libp2p; // TODO: make libp2p include it; |
There was a problem hiding this comment.
Still need to check if it is possible to get rid of.
There was a problem hiding this comment.
Do not see any way of removing it. Merging with it for now
danisharora099
force-pushed
the
weboko/libp2p.45
branch
from
6a310c1
to
18aee0c
Compare
danisharora099
force-pushed
the
weboko/libp2p.45
branch
from
bd5c617
to
ac2e900
Compare
Merged
Closed
This was referenced Sep 11, 2023
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have to update
libp2pto a newer version to bring new things such asservices(#1392) and unlock us to useWebRTCtransport for our experiments (#1181).Solution
Update the lib.
Notes