Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer not found despite using waitForRemotePeer #913

Closed
fryorcraken opened this issue Aug 30, 2022 · 6 comments
Closed

Peer not found despite using waitForRemotePeer #913

fryorcraken opened this issue Aug 30, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@fryorcraken
Copy link
Collaborator

fryorcraken commented Aug 30, 2022

When using waitForRemotePeer with store, a strange behaviour happens with the underlying libp2p peerStore:

  1. waitForRemotePeer resolves, I can confirm that the peerStore contains a peer with store protocol.
  2. Use WakuStore.queryHistory: exception is thrown because it could not find a peer in the peer store: Failed to retrieve messages Failed to find known peer that registers waku store protocol
  3. Then the peer re-appears in the peer store.

When looking at the logs, I can see a lot of events on the peerStore. the addition and removal and re-addition of the peer is unexpected.

@danisharora099
Copy link
Collaborator

How can this be reproduced?
The store tests, that use waitForRemotePeer and queries, pass correctly.

@fryorcraken
Copy link
Collaborator Author

try with store-js example see if it happens for you.

@danisharora099
Copy link
Collaborator

Unable to reproduce this withqueryOrderedCallback - retrieving all messages successfully.
Does the store-js example not work for you completely?

@fryorcraken

@danisharora099
Copy link
Collaborator

2. Use `WakuStore.queryHistory`: exception is thrown because it could not find a peer in the peer store: ` Failed to retrieve messages Failed to find known peer that registers waku store protocol`

What is the function queryHistory?

@weboko
Copy link
Collaborator

weboko commented Jan 11, 2023

I am no able to repro this issue in the store-js example.

@fryorcraken
Copy link
Collaborator Author

Ok, let's assume local fluke until further reporting

@github-project-automation github-project-automation bot moved this from Todo to Done in Waku Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants