Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode and use waku2 key in ENRs. #405

Closed
2 tasks done
D4nte opened this issue Jan 13, 2022 · 1 comment
Closed
2 tasks done

Decode and use waku2 key in ENRs. #405

D4nte opened this issue Jan 13, 2022 · 1 comment
Assignees

Comments

@D4nte
Copy link
Contributor

D4nte commented Jan 13, 2022

Problem

The waku2 key was added to Waku's ENR: https://rfc.vac.dev/spec/31/ to convey the capabilities of a node (Relay, Store, etc).

This is currently not used in the DNS Discovery implementation. Meaning that we hope for the best that the node we connect to has the capabilities we need

DoD

@D4nte D4nte changed the title Decode and use waku key in ENRs. Decode and use waku2 key in ENRs. Jan 13, 2022
@D4nte D4nte mentioned this issue Jan 13, 2022
1 task
status-bors-ng bot added a commit that referenced this issue Mar 24, 2022
620: Implementing RFC 31/WAKU2-ENR (Part 1) r=jemboh a=jemboh

## Problem

As per the [spec](https://rfc.vac.dev/spec/31/#waku2-enr-key), adding the capabilities (E.g. relay, store, filter, lightpush) of a node to the DNS discovery mechanism.

## Solution

Added the ability to get/set `waku2` field on the enr.
The `waku2` field needs to be encoded/decoded (`Waku2` object <-> `Uint8Array`) so added a _codec_ to do so.


## Notes

- Related to #405


Co-authored-by: jemboh <[email protected]>
@D4nte
Copy link
Contributor Author

D4nte commented May 5, 2022

Done with #632

@D4nte D4nte closed this as completed May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants