Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: investigate peer:identify timeouts #1431

Closed
weboko opened this issue Jul 25, 2023 · 3 comments
Closed

chore: investigate peer:identify timeouts #1431

weboko opened this issue Jul 25, 2023 · 3 comments
Labels
bug Something isn't working infra Infra, devops, CI and related tasks test Issue related to the test suite with no expected consequence to production code

Comments

@weboko
Copy link
Collaborator

weboko commented Jul 25, 2023

This is a bug report

Problem

After migration to libp2p #1400 it appeared that waiting for peer:identify is decreasing the reliability of peer exchange tests significantly. Locally it is passing but in the pipelines it times out.

Proposed Solutions

Investigate why it started happening more often (it was happening before) and what can be done to bring this testing back since some consumers of js-waku might rely on the event and the presence of the protocol.

Notes

Commit with the test - 32f6650

@weboko weboko added test Issue related to the test suite with no expected consequence to production code infra Infra, devops, CI and related tasks labels Jul 25, 2023
@weboko weboko added this to Waku Jul 25, 2023
@weboko weboko changed the title chore: investigate peer:identify chore: investigate peer:identify timeouts Jul 25, 2023
@weboko weboko moved this to Triage in Waku Jul 25, 2023
@danisharora099
Copy link
Collaborator

@danisharora099 observed that the tests failed occasionally before the upgrade as well; perhaps the libp2p upgrade made it more unreliable.
the general idea maybe can to investigate WHY this is even happening, while other tests work.

for eg:
dns compliance tests have not shown any unreliability in terms of success.

@danisharora099 danisharora099 added the bug Something isn't working label Aug 3, 2023
@danisharora099 danisharora099 moved this from Triage to To Do in Waku Aug 3, 2023
@danisharora099
Copy link
Collaborator

danisharora099 commented Aug 9, 2023

@weboko while I agree that I have witnessed Peer Exchange compliance tests failing in the CI occasionally (and works on reruns randomly); testing with the commit/test you attached above, I am unable to repro this: #1467

I'm continuing to investigate particularly from compliance test point of view.

Update: #1468 should help!

@danisharora099
Copy link
Collaborator

closed with #1468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infra Infra, devops, CI and related tasks test Issue related to the test suite with no expected consequence to production code
Projects
Archived in project
Development

No branches or pull requests

3 participants