-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: investigate peer:identify timeouts #1431
Comments
@danisharora099 observed that the tests failed occasionally before the upgrade as well; perhaps the libp2p upgrade made it more unreliable. for eg: |
@weboko while I agree that I have witnessed Peer Exchange compliance tests failing in the CI occasionally (and works on reruns randomly); testing with the commit/test you attached above, I am unable to repro this: #1467 I'm continuing to investigate particularly from compliance test point of view. Update: #1468 should help! |
closed with #1468 |
This is a bug report
Problem
After migration to
libp2p
#1400 it appeared that waiting forpeer:identify
is decreasing the reliability of peer exchange tests significantly. Locally it is passing but in the pipelines it times out.Proposed Solutions
Investigate why it started happening more often (it was happening before) and what can be done to bring this testing back since some consumers of
js-waku
might rely on the event and the presence of the protocol.Notes
Commit with the test - 32f6650
The text was updated successfully, but these errors were encountered: